Skip to content

FINERACT-2499: Update stale repayment schedule expectations for scheduler conflict scenario#5567

Open
dapzthelegend wants to merge 1 commit intoapache:developfrom
dapzthelegend:FINERACT/2499-FIX
Open

FINERACT-2499: Update stale repayment schedule expectations for scheduler conflict scenario#5567
dapzthelegend wants to merge 1 commit intoapache:developfrom
dapzthelegend:FINERACT/2499-FIX

Conversation

@dapzthelegend
Copy link

Description

Two E2E scenarios failed due to strict repayment schedule in Gherkin tables. The test outputs showed small rounding differences between expected and actual schedule values after scheduler processing.

This was due to stale expected data in feature files.

Scope

  • Affected tests:
    • LoanDelayedScheduleCaptures.feature
      Scenario: Verify full term tranche - charge waive and undo waive after 2nd disbursement - UC15
    • LoanReAmortization.feature
      Scenario: Verify Re-amortization with overdue penalties - Interest calculation: Default Behavior - Re-amortization with overdue penalties
  • No production code changes.
  • No dependency changes.
  • No behavior changes in implementation.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@IOhacker
Copy link
Contributor

IOhacker commented Mar 1, 2026

Sign your commit

All committers already have PGP/GPG keys, so just make sure you're also signing commits. You can add this to your ~/.gitconfig (or equivalent) to do it automatically:

[commit]
gpgSign = true

Upload your public key to github to make the verified badges green.

More info: FINERACT-2177, PR #5431.

Hints: 1) try it locally before pushing. 2) have git run it for you: Create .git/hooks/pre-push with:

#!/bin/sh
scripts/verify-signed-commits.sh --strict

Be sure to make that script executable.

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly see my comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants